Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag-based dynamic versioning #55

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

Sparks29032
Copy link
Collaborator

Removed support for 3.8 (importlib not available).
Updated readme instructions.
Simple tag-based dynamic versioning (same as old setup.py versioning process).

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.49%. Comparing base (52961a6) to head (02440f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   50.49%   50.49%           
=======================================
  Files          15       15           
  Lines         701      701           
=======================================
  Hits          354      354           
  Misses        347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sparks29032 Sparks29032 requested a review from sbillinge March 18, 2024 05:39
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


python setup.py develop --user
Note that this is only supported for `setuptools` version 62.0 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this, do we just want to pin setuptools in the requirements to be >=62.0?

@sbillinge sbillinge merged commit 14ad3d9 into diffpy:main Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants